Chromium Code Reviews

Issue 1323613004: [Custom Tab]Adjust padding for "Powered by Chrome" prompt text (Closed)

Created:
5 years, 3 months ago by Ian Wen
Modified:
5 years, 3 months ago
Reviewers:
aurimas (slooooooooow), Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tab]Adjust padding for "Powered by Chrome" prompt text Modifying the padding of the last menu item view is hard, but adjust the height of the prompt view is lighter and easier. This CL takes this approach to make the padding for each menu more symmetric. BUG=527537 R=yusufo@chromium.org Committed: https://crrev.com/efe475ce3e0cd00f1edc0a905c40e8f7f8d90937 Cr-Commit-Position: refs/heads/master@{#347345}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+15 lines, -11 lines)
M chrome/android/java/res/layout/powered_by_chrome_footer.xml View 1 chunk +9 lines, -7 lines 0 comments
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -1 line 0 comments
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 2 chunks +6 lines, -3 lines 0 comments

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Ian Wen
PTAL :)
5 years, 3 months ago (2015-09-03 05:54:09 UTC) #1
Ian Wen
aurimas@chromium.org: Could you help me review the menu change? Thanks!
5 years, 3 months ago (2015-09-03 18:04:04 UTC) #3
aurimas (slooooooooow)
lgtm given than rolfe@ is ok with the white gap one the last menu item ...
5 years, 3 months ago (2015-09-03 20:08:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323613004/1
5 years, 3 months ago (2015-09-03 21:14:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323613004/1
5 years, 3 months ago (2015-09-04 06:28:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 06:33:22 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 06:34:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efe475ce3e0cd00f1edc0a905c40e8f7f8d90937
Cr-Commit-Position: refs/heads/master@{#347345}

Powered by Google App Engine