Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1284493002: Make the button in snackbar larger and easier to click (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the button in snackbar larger and easier to click Snackbar button was too small, and in fact the only touchable area was the text itself. This makes the button hard to touch, especially for visually impaired personels. This CL also adds ianwen@ as the owner of snackbar folder. BUG=NONE Committed: https://crrev.com/68c2560ea4411b19ca87f4655f4ea374d753cb6b Cr-Commit-Position: refs/heads/master@{#342758}

Patch Set 1 #

Total comments: 4

Patch Set 2 : textview -> button #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/android/java/res/layout/snackbar.xml View 1 2 chunks +7 lines, -7 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/snackbar/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
Ian Wen
5 years, 4 months ago (2015-08-08 00:51:43 UTC) #2
newt (away)
https://codereview.chromium.org/1284493002/diff/1/chrome/android/java/res/layout/snackbar.xml File chrome/android/java/res/layout/snackbar.xml (right): https://codereview.chromium.org/1284493002/diff/1/chrome/android/java/res/layout/snackbar.xml#newcode29 chrome/android/java/res/layout/snackbar.xml:29: android:layout_height="@dimen/snackbar_min_height" how about just match_parent here? https://codereview.chromium.org/1284493002/diff/1/chrome/android/java/res/layout/snackbar.xml#newcode30 chrome/android/java/res/layout/snackbar.xml:30: android:background="?attr/selectableItemBackground" ...
5 years, 4 months ago (2015-08-08 01:11:27 UTC) #3
Ian Wen
https://codereview.chromium.org/1284493002/diff/1/chrome/android/java/res/layout/snackbar.xml File chrome/android/java/res/layout/snackbar.xml (right): https://codereview.chromium.org/1284493002/diff/1/chrome/android/java/res/layout/snackbar.xml#newcode29 chrome/android/java/res/layout/snackbar.xml:29: android:layout_height="@dimen/snackbar_min_height" On 2015/08/08 01:11:27, newt wrote: > how about ...
5 years, 4 months ago (2015-08-10 22:40:10 UTC) #4
newt (away)
lgtm
5 years, 4 months ago (2015-08-10 22:59:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284493002/20001
5 years, 4 months ago (2015-08-11 00:12:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 00:49:28 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 00:50:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68c2560ea4411b19ca87f4655f4ea374d753cb6b
Cr-Commit-Position: refs/heads/master@{#342758}

Powered by Google App Engine
This is Rietveld 408576698