Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1208503002: Let product name be visible in app menu of custom tabs (Closed)

Created:
5 years, 6 months ago by Ian Wen
Modified:
5 years, 6 months ago
Reviewers:
Yusuf, newt (away)
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let product name be visible in app menu of custom tabs As an effort to make users realize they are in chrome, not in client app, "open in chrome" should be replaced to "open in ${product_name}", where product_name is the name of different channels. BUG=NONE Committed: https://crrev.com/db8f9a32e161f0ea386750ad83635470836aa31f Cr-Commit-Position: refs/heads/master@{#335966}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/android/java/res/menu/custom_tabs_menu.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 2 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Ian Wen
ptal.:P
5 years, 6 months ago (2015-06-24 17:32:50 UTC) #2
newt (away)
lgtm after question https://codereview.chromium.org/1208503002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/1208503002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode1930 chrome/android/java/strings/android_chrome_strings.grd:1930: <message name="IDS_MENU_OPEN_IN_CHROME" desc="Context sensitive menu item ...
5 years, 6 months ago (2015-06-24 18:03:51 UTC) #3
Ian Wen
https://codereview.chromium.org/1208503002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/1208503002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode1930 chrome/android/java/strings/android_chrome_strings.grd:1930: <message name="IDS_MENU_OPEN_IN_CHROME" desc="Context sensitive menu item for opening a ...
5 years, 6 months ago (2015-06-24 18:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208503002/1
5 years, 6 months ago (2015-06-24 18:15:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 19:01:49 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 19:02:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8f9a32e161f0ea386750ad83635470836aa31f
Cr-Commit-Position: refs/heads/master@{#335966}

Powered by Google App Engine
This is Rietveld 408576698