Stop UI jumping when clicking Contextual Search Results in Custom Tab

Stop UI jumping when clicking Contextual Search Results in Custom Tab

In a custom tab, Contextual search's result will be loaded in the same
tab, therefore if the contextual search's panel was launched by long
click then the CAB(copy paste bar) will flicker.

This CL makes custom tab's toolbar below the CAB (this is already the
behavior for normal chrome tab). Also it tries its best to dismiss the
CAB ASAP after clicking.

BUG=510284
Committed: https://crrev.com/c30fdeb25a3411b6bf8f0a6cd90d81895b6d0fa4
Cr-Commit-Position: refs/heads/master@{#341623}

[Ian Wen, 2015-07-15 21:47:37]

ianwen@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org, yusufo@chromium.org

[Ian Wen, 2015-07-20 18:07:04]

ianwen@chromium.org changed reviewers:
+ twellington@chromium.org
- pedrosimonetti@chromium.org

[Ian Wen, 2015-07-20 18:07:04]

Theresa, could you ptal?

[Theresa, 2015-07-20 18:15:10]

lgtm

[Yusuf, 2015-07-23 05:23:34]

https://codereview.chromium.org/1235383002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/1235383002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values-v17/styles.xml:23: <item
name="windowActionModeOverlay">true</item>
why do we need this one? Does it not change the behavior for the other
activities?

[Ian Wen, 2015-07-29 01:15:06]

ptal. :)

https://codereview.chromium.org/1235383002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/1235383002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values-v17/styles.xml:23: <item
name="windowActionModeOverlay">true</item>
On 2015/07/23 05:23:34, Yusuf wrote:
> why do we need this one? Does it not change the behavior for the other
> activities?

Oh. This flag is to tell the CAB bar to overlay on chrome's content, instead of
squeezing the entire UI downwards. (Similar to use framelayout instead of
vertical linearlayout.)

In chromeTabbedActivity and DocumentActivity we already sets this flag
programatically. Yet it seems having an xml configuration is too wide and it
harms web apps. I moved this flag to the activity.

[Yusuf, 2015-08-03 21:05:21]

lgtm

[Ian Wen, 2015-08-03 21:05:34]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-03 21:05:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/1235383002/#ps20001
(title: "move flag from xml to java")

[commit-bot: I haz the power, 2015-08-03 21:05:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1235383002/20001

[commit-bot: I haz the power, 2015-08-03 21:46:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-03 21:47:26]

Patchset 2 (id:??) landed as
https://crrev.com/c30fdeb25a3411b6bf8f0a6cd90d81895b6d0fa4
Cr-Commit-Position: refs/heads/master@{#341623}