Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1250853005: Fix a bug that snackbar is drawn under navigagion bar (Closed)

Created:
5 years, 5 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, ianwen+watch_chromium.org, Theresa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that snackbar is drawn under navigagion bar In L apps are able to extend itself under the navigation bar. Yet this feature is not needed in enhanced bookmarks, and it caused a UI bug with snackbar. BUG=508873 Committed: https://crrev.com/5476228290d10bb5d02ffdee8e096c3a3a77637a Cr-Commit-Position: refs/heads/master@{#339800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Ian Wen
5 years, 5 months ago (2015-07-21 22:46:55 UTC) #2
newt (away)
lgtm
5 years, 5 months ago (2015-07-21 22:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250853005/1
5 years, 5 months ago (2015-07-21 22:54:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 00:49:20 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5476228290d10bb5d02ffdee8e096c3a3a77637a Cr-Commit-Position: refs/heads/master@{#339800}
5 years, 5 months ago (2015-07-22 00:50:14 UTC) #7
Ian Wen
5 years, 4 months ago (2015-07-27 22:07:45 UTC) #8
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698