Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1234343002: Break getBookmarkTitle() to two lines to see which object can be null (Closed)

Created:
5 years, 5 months ago by Ian Wen
Modified:
5 years, 5 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break getBookmarkTitle() to two lines to see which object can be null We saw some NPE in getBookmarkTitle() and we are not sure which object was null at the time. BUG=504317 Committed: https://crrev.com/295948c21392180f5e3227f282ef374df5245c8f Cr-Commit-Position: refs/heads/master@{#339151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Ian Wen
5 years, 5 months ago (2015-07-16 00:14:02 UTC) #2
Kibeom Kim (inactive)
lgtm
5 years, 5 months ago (2015-07-16 00:18:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234343002/1
5 years, 5 months ago (2015-07-16 00:21:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/92139) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-16 00:28:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234343002/1
5 years, 5 months ago (2015-07-16 22:40:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 22:58:07 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 22:59:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/295948c21392180f5e3227f282ef374df5245c8f
Cr-Commit-Position: refs/heads/master@{#339151}

Powered by Google App Engine
This is Rietveld 408576698