Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263583003: Let client app customize close button (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
Benoit L, Yusuf
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let client app customize close button There has been strong feedback requesting customizeable close button. This CL implements it by getting a bitmap from the passed intent. BUG=513512 Committed: https://crrev.com/75e3fda0d374a97922177d55803dbe36962d364e Cr-Commit-Position: refs/heads/master@{#340941}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Messages

Total messages: 10 (3 generated)
Ian Wen
lizeb@chromium.org: Please review changes in yusufo@chromium.org: Please review changes in
5 years, 4 months ago (2015-07-28 22:33:27 UTC) #2
Yusuf
lgtm
5 years, 4 months ago (2015-07-29 04:48:25 UTC) #3
Benoit L
lgtm. https://codereview.chromium.org/1263583003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java (right): https://codereview.chromium.org/1263583003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java#newcode46 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:46: * not to customize it, a default close ...
5 years, 4 months ago (2015-07-29 14:32:28 UTC) #4
Ian Wen
https://codereview.chromium.org/1263583003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java (right): https://codereview.chromium.org/1263583003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java#newcode46 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:46: * not to customize it, a default close button ...
5 years, 4 months ago (2015-07-29 18:26:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263583003/20001
5 years, 4 months ago (2015-07-29 18:28:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 19:07:11 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 19:08:25 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/75e3fda0d374a97922177d55803dbe36962d364e
Cr-Commit-Position: refs/heads/master@{#340941}

Powered by Google App Engine
This is Rietveld 408576698