Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1346403005: Another effort to fix WebRTC notification for Custom Tabs (Closed)

Created:
5 years, 3 months ago by Ian Wen
Modified:
5 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Another effort to fix WebRTC notification for Custom Tabs In https://codereview.chromium.org/1327193004, "Touch to return" was removed from all normal chrome tabs, an it was added only to Custom tabs. This is exactly the opposite behavior we expect. This CL fixes the string mistake. BUG=524855 Committed: https://crrev.com/e768e0cd80bd2f284a89ca476669de5cc145c105 Cr-Commit-Position: refs/heads/master@{#349296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Ian Wen
Sorry to pester you again, Dan. (≧▼≦;)
5 years, 3 months ago (2015-09-16 23:45:52 UTC) #2
gone
lgtm
5 years, 3 months ago (2015-09-16 23:47:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346403005/1
5 years, 3 months ago (2015-09-16 23:50:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 00:48:17 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 00:48:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e768e0cd80bd2f284a89ca476669de5cc145c105
Cr-Commit-Position: refs/heads/master@{#349296}

Powered by Google App Engine
This is Rietveld 408576698