Let client specify content description for custom action button

Let client specify content description for custom action button

Per accessibility review, the custom action button should always carry
meaningful content description. This CL adds a key for the custom button
bundle in intent.

BUG=516465
Committed: https://crrev.com/a2e5182ec55cfd1edd38c52a250ec12dde3e4295
Cr-Commit-Position: refs/heads/master@{#342916}

[Ian Wen, 2015-08-05 00:28:18]

ianwen@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2015-08-05 18:43:04]

https://codereview.chromium.org/1263573011/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/custom_tabs_toolbar.xml (left):

https://codereview.chromium.org/1263573011/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/custom_tabs_toolbar.xml:71:
android:contentDescription="@string/accessibility_toolbar_btn_custom" />
We might still want to keep this to avoid lint getting unhappy.

https://codereview.chromium.org/1263573011/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/1263573011/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:129:
if (mCustomButtonIcon == null) {
I think the idea is this becomes a must. Anybody who adds an icon and pending
intent, should be adding this a nonempty as well.

https://codereview.chromium.org/1263573011/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
(right):

https://codereview.chromium.org/1263573011/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java:233:
if (description == null) return false;
TextUtils.isEmpty

[Ian Wen, 2015-08-05 21:22:45]

All done.

One remaining question is that if I land this CL to M45, then it will block our
sample app from showing any custom button. And there is no easy way let the
client supports adding a string to bundle, without adding code to android
support library.

[Yusuf, 2015-08-10 05:49:36]

lgtm after a few more renamings

https://codereview.chromium.org/1263573011/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/1263573011/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:222:
public boolean shouldShowActionButton() {
CustomButton?

https://codereview.chromium.org/1263573011/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:237:
public String getActionButtonDescription() {
CustomButton

https://codereview.chromium.org/1263573011/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:246:
public PendingIntent getActionButtonPendingIntentForTest() {
custombutton

[Yusuf, 2015-08-11 16:55:29]

we can land this now.

[Ian Wen, 2015-08-11 16:56:08]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org

[Ian Wen, 2015-08-11 16:56:09]

newt@chromium.org: Please review changes in strings.grd

[newt (away), 2015-08-11 18:42:50]

android_chrome_strings.grd lgtm

[Ian Wen, 2015-08-11 18:54:04]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2015-08-11 18:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263573011/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263573011/40001

[Ian Wen, 2015-08-11 18:54:22]

The CQ bit was unchecked by ianwen@chromium.org

[Ian Wen, 2015-08-11 21:18:16]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-11 21:18:17]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1263573011/#ps60001
(title: "remove a todo of mine")

[commit-bot: I haz the power, 2015-08-11 21:18:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263573011/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263573011/60001

[Ian Wen, 2015-08-11 21:20:35]

The CQ bit was unchecked by ianwen@chromium.org

[Ian Wen, 2015-08-11 21:32:00]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-11 21:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1263573011/#ps80001
(title: "fix corresponding test")

[commit-bot: I haz the power, 2015-08-11 21:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263573011/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263573011/80001

[commit-bot: I haz the power, 2015-08-11 22:20:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-11 22:21:19]

Patchset 5 (id:??) landed as
https://crrev.com/a2e5182ec55cfd1edd38c52a250ec12dde3e4295
Cr-Commit-Position: refs/heads/master@{#342916}