Issue 1283123003: Catch partner bookmark related crash in EBEditActivity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283123003: Catch partner bookmark related crash in EBEditActivity (Closed)

Created:
5 years, 4 months ago by Ian Wen

Modified:
4 years, 10 months ago

Reviewers:
Kibeom Kim (inactive)

CC:
chromium-reviews, ianwen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Catch partner bookmark related crash in EBEditActivity If a partner bookmark is deleted, bookmarkNodeRemoved() will not be called. This CL catches that. BUG=504317

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java	View		4 chunks	+1 line, -8 lines	0 comments	Download

Depends on Patchset:

Issue 669623008 Patch 20001

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kibeom Kim (inactive)

5 years, 4 months ago (2015-08-12 01:34:11 UTC) #3

Thanks, seems good. But have you tested manually? If not, I can give you an
instruction tomorrow.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages