Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1379663004: Removed usage of deprecated API setWindowLayoutMode (Closed)

Created:
5 years, 2 months ago by Ian Wen
Modified:
5 years, 2 months ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed usage of deprecated API setWindowLayoutMode setWindowLayoutMode has been deprecated and we should use setHeight and setWidth instead. BUG=537051 R=aurimas@chromium.org,twellington@chromium.org Committed: https://crrev.com/b770d10a0ed4c62e2e6352a2efd2d2865610329e Cr-Commit-Position: refs/heads/master@{#351656}

Patch Set 1 #

Patch Set 2 : one more file #

Messages

Total messages: 18 (5 generated)
Ian Wen
ptal. :)
5 years, 2 months ago (2015-09-29 23:22:40 UTC) #2
aurimas (slooooooooow)
Could we also fix ValidationMessageBubble.java?
5 years, 2 months ago (2015-09-29 23:25:00 UTC) #3
Ian Wen
Done.
5 years, 2 months ago (2015-09-29 23:30:38 UTC) #4
aurimas (slooooooooow)
lgtm
5 years, 2 months ago (2015-09-29 23:31:18 UTC) #5
Theresa
lgtm
5 years, 2 months ago (2015-09-30 01:33:00 UTC) #6
David Trainor- moved to gerrit
lgtm
5 years, 2 months ago (2015-09-30 14:51:50 UTC) #7
Ian Wen
Hi Ted, could you ptal at the component folder change? Thanks!
5 years, 2 months ago (2015-09-30 20:52:49 UTC) #10
Ted C
lgtm
5 years, 2 months ago (2015-09-30 20:57:02 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379663004/20001
5 years, 2 months ago (2015-09-30 21:02:27 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 21:59:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379663004/20001
5 years, 2 months ago (2015-09-30 22:04:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 22:13:17 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 22:14:11 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b770d10a0ed4c62e2e6352a2efd2d2865610329e
Cr-Commit-Position: refs/heads/master@{#351656}

Powered by Google App Engine
This is Rietveld 408576698