Refactor chrome's action mode logics and namings

Refactor chrome's action mode logics and namings

ActionMode is the standard naming for the copy-paste-select bar in
android. (http://developer.android.com/guide/topics/ui/menus.html) In
chrome on android, three types of ActionMode exist:
1. ContextualMenuBar and CustomSelectionActionModeCallback. This is for
toolbar and omnibox editing. On tablet, ContextualMenuBar controls the
animation to move toolbar downwards, hiding the tabstrip.
2. SelectionActionModeCallback and SelectionActionMode are content
layer concept for selecting strings inside of the webcontents.
3. ChromeSelectActionModeCallback is the same thing in chrome layer.

To make our naming more clear and more intuitive, several renamings are
proposed in this CL:
1. ContextualMenuBar -> ActionModeController. This class only handles
animation for toolbar, and it is essentially a controller/manager.
2. CustomSelectionActionModeCallback -> ToolbarActionModeCallback. This
callback only serves content editing in toolbar and omnibox.
3. SelectActionMode -> WebActionMode; SelectActionModeCallback ->
WebActionModeCallback. This renaming is to distinguish between
webcontents and android native views.

This CL also removes the unused code in ChromeTabbedActivity.

BUG=521194
Committed: https://crrev.com/6b5e238f0ee7db98535c3b459d0a14194efccfc3
Cr-Commit-Position: refs/heads/master@{#344336}

[Ian Wen, 2015-08-14 23:33:56]

ianwen@chromium.org changed reviewers:
+ boliu@chromium.org, dtrainor@chromium.org

[Ian Wen, 2015-08-14 23:33:56]

boliu@chromium.org: Please review changes in webview.

dtrainor@chromium.org: Please review changes in chrome on android.

[David Trainor- moved to gerrit, 2015-08-18 18:32:50]

chrome android changes lgtm with a few nits.

https://chromiumcodereview.appspot.com/1292923004/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeActionModeCallback.java
(right):

https://chromiumcodereview.appspot.com/1292923004/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeActionModeCallback.java:20:
public class ChromeActionModeCallback extends WebActionModeCallback {
Is ChromeWebActionModeCallback better?

https://chromiumcodereview.appspot.com/1292923004/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java
(right):

https://chromiumcodereview.appspot.com/1292923004/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java:26:
private ToolbarActionModeCallback mCustomSelectionActionModeCallback;
change variable name too?

https://chromiumcodereview.appspot.com/1292923004/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java:105:
ToolbarActionModeCallback customSelectionActionModeCallback) {
Change parameter name too?

[boliu, 2015-08-18 18:37:48]

rs lgtm

[Ian Wen, 2015-08-19 18:35:36]

Thanks for the accurate comments, David. All addressed.

https://codereview.chromium.org/1292923004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeActionModeCallback.java
(right):

https://codereview.chromium.org/1292923004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeActionModeCallback.java:20:
public class ChromeActionModeCallback extends WebActionModeCallback {
On 2015/08/18 18:32:50, David Trainor wrote:
> Is ChromeWebActionModeCallback better?

Done.

https://codereview.chromium.org/1292923004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java
(right):

https://codereview.chromium.org/1292923004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java:26:
private ToolbarActionModeCallback mCustomSelectionActionModeCallback;
On 2015/08/18 18:32:50, David Trainor wrote:
> change variable name too?

Done.

https://codereview.chromium.org/1292923004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java:105:
ToolbarActionModeCallback customSelectionActionModeCallback) {
On 2015/08/18 18:32:50, David Trainor wrote:
> Change parameter name too?

Done.

[Ian Wen, 2015-08-19 18:35:43]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-19 18:35:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/1292923004/#ps20001
(title: "respond to comments")

[commit-bot: I haz the power, 2015-08-19 18:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1292923004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1292923004/20001

[commit-bot: I haz the power, 2015-08-19 19:02:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 19:02:04]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Ian Wen, 2015-08-19 20:13:40]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-19 20:13:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/1292923004/#ps40001
(title: "make webview to compile")

[commit-bot: I haz the power, 2015-08-19 20:13:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1292923004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1292923004/40001

[commit-bot: I haz the power, 2015-08-19 21:38:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-19 21:39:12]

Patchset 3 (id:??) landed as
https://crrev.com/6b5e238f0ee7db98535c3b459d0a14194efccfc3
Cr-Commit-Position: refs/heads/master@{#344336}