Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1311873002: Fix a crash about opening a folder that was deleted by sync (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash about opening a folder that was deleted by sync If a bookmark is deleted by sync, bookmarkNodeRemoved() will not be called in EBManager. BUG=523924 Committed: https://crrev.com/1a13565a349cba0d2f44a3cb9fbb94ccbb9341f9 Cr-Commit-Position: refs/heads/master@{#345125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Ian Wen
5 years, 4 months ago (2015-08-24 17:44:29 UTC) #2
Kibeom Kim (inactive)
lgtm
5 years, 4 months ago (2015-08-24 17:47:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311873002/1
5 years, 4 months ago (2015-08-24 17:53:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 18:24:41 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 18:25:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a13565a349cba0d2f44a3cb9fbb94ccbb9341f9
Cr-Commit-Position: refs/heads/master@{#345125}

Powered by Google App Engine
This is Rietveld 408576698