Issue 1342343002: Make menu hardware key work on Custom Tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1342343002: Make menu hardware key work on Custom Tabs (Closed)

Created:
5 years, 3 months ago by Ian Wen

Modified:
5 years, 3 months ago

Reviewers:
Yusuf

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make menu hardware key work on Custom Tabs Menu key was not supported before in custom tabs. This CL adds the support. BUG=513770 Committed: https://crrev.com/e40ca9288a83995bf4222067c17f03015b1be1db Cr-Commit-Position: refs/heads/master@{#349289}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java	View		4 chunks	+12 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 669623008 Patch 20001

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342343002/1

5 years, 3 months ago (2015-09-16 23:06:42 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-17 00:22:24 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e40ca9288a83995bf4222067c17f03015b1be1db
Cr-Commit-Position: refs/heads/master@{#349289}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages