Chromium Code Reviews

Issue 1268403004: Make bookmark related tests not flaky (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
gone, Kibeom Kim (inactive)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make bookmark related tests not flaky BookmarksBridgeTest and EnhancedBookmarksModelTest are no longer chrome shell tests. They are now running as NativeLibraryTest and have much shorter initialization time. Therefore there are great chances that the model is not loaded when getMobileFolderId() is called. This CL adds criteria to check whether the bridge has loaded or not, and pause the UI thread for a while. BUG=515489 Committed: https://crrev.com/7f79a1dbe726730103b4a814cc291eb0f661201e Cr-Commit-Position: refs/heads/master@{#342144}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+36 lines, -9 lines)
M chrome/android/javatests/src/org/chromium/chrome/browser/BookmarksBridgeTest.java View 2 chunks +15 lines, -0 lines 0 comments
M chrome/android/javatests/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModelTest.java View 5 chunks +21 lines, -9 lines 0 comments

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Ian Wen
Since Ted is OOO, Dan, as a rock star in java testing, could you ptal? ...
5 years, 4 months ago (2015-08-06 00:35:57 UTC) #2
gone
Your message drips with sarcasm, but lgtm :P
5 years, 4 months ago (2015-08-06 17:05:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268403004/1
5 years, 4 months ago (2015-08-06 17:14:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 17:48:43 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7f79a1dbe726730103b4a814cc291eb0f661201e Cr-Commit-Position: refs/heads/master@{#342144}
5 years, 4 months ago (2015-08-06 17:49:56 UTC) #7
Kibeom Kim (inactive)
5 years, 4 months ago (2015-08-06 18:04:20 UTC) #9
Message was sent while issue was closed.
minor point: I think it's better to listen bookmark model loaded event by an
observer because there is a default timeout for polling so not guaranteed.
Though probably wouldn't fail in practice so I think it's OK for now.

Powered by Google App Engine