Expose custom tab client gyp target in chromium

Expose custom tab client gyp target in chromium

A custom tab client project has been mirrored in third_party. We
should add a gyp target to compile it in upstream, and delete the
downstream one.

This CL also updated java.gypi to let it take customizable
src suffix, just like java_apk.gypi.

BUG=510083
Committed: https://crrev.com/059d5d826a3803cdb4a18f217503bf6860463b3b
Cr-Commit-Position: refs/heads/master@{#338399}

[Ian Wen, 2015-07-07 01:50:39]

ianwen@chromium.org changed reviewers:
+ cjhopman@chromium.org

[Ian Wen, 2015-07-07 01:50:39]

Hello Chris, could you please take a look at this CL?

The gyp target in question is brought in
https://chromium-review.googlesource.com/#/c/283519/2, and will be in
third_party/custom_tabs_client/src. Currently gn is not supported yet.

[Ian Wen, 2015-07-07 16:26:11]

ianwen@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2015-07-07 17:56:12]

lgtm if cjhopman approves

https://codereview.chromium.org/1222403005/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/1222403005/diff/1/build/all.gyp#newcode890
build/all.gyp:890:
'../third_party/custom_tabs_client/src/custom_tabs_client.gyp:custom_tabs_client_example_apk',
the comment above suggests adding it to
build/android/pylib/gtest/gtest_config.py, is it not necessary in this case?

Also, did you communicate "the implications" with the
chrome-infrastructure-team@ as suggested?

[cjhopman, 2015-07-07 18:47:49]

lgtm

[Ian Wen, 2015-07-09 18:41:33]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2015-07-09 18:42:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1222403005/1

[commit-bot: I haz the power, 2015-07-09 19:27:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 19:27:07]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[cjhopman, 2015-07-10 22:45:29]

still lgtmn

[Ian Wen, 2015-07-10 22:46:52]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-07-10 22:46:53]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
cjhopman@chromium.org
Link to the patchset: https://codereview.chromium.org/1222403005/#ps40001
(title: "roll custom_tabs_client in third_party")

[commit-bot: I haz the power, 2015-07-10 22:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1222403005/40001

[commit-bot: I haz the power, 2015-07-10 23:51:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-10 23:51:58]

Patchset 3 (id:??) landed as
https://crrev.com/059d5d826a3803cdb4a18f217503bf6860463b3b
Cr-Commit-Position: refs/heads/master@{#338399}