Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1372283003: Remove a piece of unused code from ApiCompatibilityUtils (Closed)

Created:
5 years, 2 months ago by Ian Wen
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a piece of unused code from ApiCompatibilityUtils setStatusBarColor() should have been removed. This CL fulfills a TODO that ianwen left. BUG=NONE Committed: https://crrev.com/adec03c97e92616741059b4e47e36275c385b159 Cr-Commit-Position: refs/heads/master@{#351224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +0 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Ian Wen
PTAL
5 years, 2 months ago (2015-09-28 22:32:24 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 2 months ago (2015-09-28 23:04:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372283003/1
5 years, 2 months ago (2015-09-28 23:06:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126605)
5 years, 2 months ago (2015-09-28 23:58:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372283003/1
5 years, 2 months ago (2015-09-29 01:15:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 01:21:22 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 01:22:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adec03c97e92616741059b4e47e36275c385b159
Cr-Commit-Position: refs/heads/master@{#351224}

Powered by Google App Engine
This is Rietveld 408576698