Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1363723003: Remove an unused enhanced bookmark histogram (Closed)

Created:
5 years, 3 months ago by Ian Wen
Modified:
5 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unused enhanced bookmark histogram EnhancedBookmark.ViewMode was used to detect how many users prefer ListView over GridView. Since now we have fully migrated to ListView, this histogram is not used anymore. BUG=NONE Committed: https://crrev.com/01940bb4055a8cb54af8d9f8074104a509dadc02 Cr-Commit-Position: refs/heads/master@{#350313}

Patch Set 1 #

Patch Set 2 : Mark obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
Ian Wen
PTAL
5 years, 3 months ago (2015-09-22 23:45:50 UTC) #3
Ilya Sherman
Please mark the histogram as <obsolete> rather than deleting it from histograms.xml. I'm assuming the ...
5 years, 3 months ago (2015-09-22 23:47:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363723003/1
5 years, 3 months ago (2015-09-22 23:47:58 UTC) #5
Ian Wen
Done. Marked obsolete
5 years, 3 months ago (2015-09-22 23:54:15 UTC) #6
Ilya Sherman
LGTM, thanks.
5 years, 3 months ago (2015-09-23 00:01:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363723003/20001
5 years, 3 months ago (2015-09-23 00:04:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 06:06:20 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 06:07:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01940bb4055a8cb54af8d9f8074104a509dadc02
Cr-Commit-Position: refs/heads/master@{#350313}

Powered by Google App Engine
This is Rietveld 408576698