Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254383014: Roll third_party/custom_tabs_client (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/custom_tabs_client Roll from 6bae8bf337d5c51184c0c01f5baca3e0858 to 19d5cb35bece11876e8f34c17c6fdfd9bad. BUG=510083 Committed: https://crrev.com/dc731ce3111a8d4f316e478601707cc33e70e542 Cr-Commit-Position: refs/heads/master@{#341048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 669623008 Patch 20001

Messages

Total messages: 8 (2 generated)
Ian Wen
5 years, 4 months ago (2015-07-29 23:23:49 UTC) #2
Yusuf
lgtm
5 years, 4 months ago (2015-07-29 23:26:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254383014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254383014/1
5 years, 4 months ago (2015-07-29 23:27:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 02:18:05 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dc731ce3111a8d4f316e478601707cc33e70e542 Cr-Commit-Position: refs/heads/master@{#341048}
5 years, 4 months ago (2015-07-30 02:19:12 UTC) #7
timvolodine
5 years, 4 months ago (2015-07-30 11:54:34 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1263983002/ by timvolodine@chromium.org.

The reason for reverting is: speculative revert, prevents clank roll downstream,
see crbug.com/515457.

Powered by Google App Engine
This is Rietveld 408576698