Make EBEditActivity more wary about bookmarkModelChange

Make EBEditActivity more wary about bookmarkModelChange

There is an unknown reason causing the current bookmarkid to be deleted
while the EBEditActivity is still showing. This CL makes a defensive
gesture torwards these events.

BUG=504317
Committed: https://crrev.com/ff18b5ff0434086f25473114beec2478a8710f4a
Cr-Commit-Position: refs/heads/master@{#342233}

[Ian Wen, 2015-08-05 23:18:12]

ianwen@chromium.org changed reviewers:
+ kkimlabs@chromium.org

[Kibeom Kim (inactive), 2015-08-06 09:41:38]

lgtm

https://codereview.chromium.org/1272863002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
(right):

https://codereview.chromium.org/1272863002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java:70:
Log.wtf(TAG, "The bookmark was deleted somehow during bookmarkModelChange!");
What if we put "new Exception(TAG)" as a third argument instead of the below
line? does that print stack trace?

https://codereview.chromium.org/1272863002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java:127:
Log.d(TAG, "Delete button pressed by user!");
Just checking: is this printed on release build?

[Kibeom Kim (inactive), 2015-08-06 09:43:42]

Also I think it's useful to log isFinishing(). e.g.,

Log.d(TAG, "Delete button pressed by user! isFinishing() == " + isFinishing());

[Ian Wen, 2015-08-06 18:22:49]

https://codereview.chromium.org/1272863002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
(right):

https://codereview.chromium.org/1272863002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java:70:
Log.wtf(TAG, "The bookmark was deleted somehow during bookmarkModelChange!");
On 2015/08/06 09:41:37, Kibeom Kim wrote:
> What if we put "new Exception(TAG)" as a third argument instead of the below
> line? does that print stack trace?

Yes it prints the stack trace. Done.

https://codereview.chromium.org/1272863002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java:127:
Log.d(TAG, "Delete button pressed by user!");
On 2015/08/06 09:41:38, Kibeom Kim wrote:
> Just checking: is this printed on release build?

Yes. If you see your logcat, you will find all sorts of logs including D logs.
The d,i,wtf all works only for priority filtering.

[Ian Wen, 2015-08-06 21:55:44]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-06 21:55:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkimlabs@chromium.org
Link to the patchset: https://codereview.chromium.org/1272863002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2015-08-06 21:57:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272863002/20001

[commit-bot: I haz the power, 2015-08-06 23:50:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-06 23:50:52]

Patchset 2 (id:??) landed as
https://crrev.com/ff18b5ff0434086f25473114beec2478a8710f4a
Cr-Commit-Position: refs/heads/master@{#342233}