Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1216963009: Make chrome custom tab's task description color same as toolbar (Closed)

Created:
5 years, 5 months ago by Ian Wen
Modified:
5 years, 5 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chrome custom tab's task description color same as toolbar Currently we do not set the task description color of the custom tab activity, hoping the original color of the client app will be preserved. However in this case the android framework will set the task color to be gray, which is not desirable. This CL sets the task color to be the same as toolbar's color. BUG=504364 Committed: https://crrev.com/9dae9d09f717f603d59a2ba78deaab0b077c5173 Cr-Commit-Position: refs/heads/master@{#338091}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 2 2 chunks +9 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
Ian Wen
5 years, 5 months ago (2015-06-30 23:24:48 UTC) #2
Yusuf
https://codereview.chromium.org/1216963009/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/1216963009/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode124 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:124: setStatusBarColor(toolbarColor); use BrandColorUtils.computeStatusBarColor(color) here since we want it slightly ...
5 years, 5 months ago (2015-07-01 17:16:37 UTC) #3
Ian Wen
:) https://codereview.chromium.org/1216963009/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/1216963009/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode124 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:124: setStatusBarColor(toolbarColor); On 2015/07/01 17:16:37, Yusuf wrote: > use ...
5 years, 5 months ago (2015-07-09 17:24:33 UTC) #4
Yusuf
lgtm
5 years, 5 months ago (2015-07-09 17:28:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216963009/40001
5 years, 5 months ago (2015-07-09 17:43:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-09 18:23:52 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 18:24:49 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9dae9d09f717f603d59a2ba78deaab0b077c5173
Cr-Commit-Position: refs/heads/master@{#338091}

Powered by Google App Engine
This is Rietveld 408576698