Move duplicate code for exiting fullscreen to ChromeActivity

Move duplicate code for exiting fullscreen to ChromeActivity

While trying to fix the wrong behavior of CustomTabActivity exiting the
video fullscreen, I realize that the piece of code should be reused by
DocumentActivity and ChromeTabbedActivity as well.

BUG=513444
Committed: https://crrev.com/0071657bfa9bbe25c408068efb0510f696803016
Cr-Commit-Position: refs/heads/master@{#350600}

[Ian Wen, 2015-09-23 01:15:18]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-09-23 22:48:29]

newt@chromium.org changed reviewers:
+ qinmin@chromium.org

[newt (away), 2015-09-23 22:48:29]

Min: could you take a look?

[qinmin, 2015-09-24 03:53:22]

lgtm

[newt (away), 2015-09-24 04:02:13]

lgtm with nit

https://codereview.chromium.org/1363763002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1363763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1214: *
Tries to exit the fullscreen mode, if any. Does nothing if no fullscreen is
present.
Does it "try" to exit fullscreen, or does it always exit fullscreen if
fullscreen is showing?

https://codereview.chromium.org/1363763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1217:
protected boolean tryExitFullScreen() {
nit: "Fullscreen" with a lowercase "s" to be consistent with other fullscreen
code.

And what about calling this "exitFullscreenIfShowing()"?

[Ian Wen, 2015-09-24 17:03:52]

https://codereview.chromium.org/1363763002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1363763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1214: *
Tries to exit the fullscreen mode, if any. Does nothing if no fullscreen is
present.
On 2015/09/24 04:02:13, newt wrote:
> Does it "try" to exit fullscreen, or does it always exit fullscreen if
> fullscreen is showing?

Done.

https://codereview.chromium.org/1363763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1217:
protected boolean tryExitFullScreen() {
On 2015/09/24 04:02:13, newt wrote:
> nit: "Fullscreen" with a lowercase "s" to be consistent with other fullscreen
> code.
> 
> And what about calling this "exitFullscreenIfShowing()"?

Done.

[Ian Wen, 2015-09-24 17:03:55]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-09-24 17:03:55]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1363763002/#ps20001
(title: "rename")

[commit-bot: I haz the power, 2015-09-24 17:04:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363763002/20001

[commit-bot: I haz the power, 2015-09-24 17:50:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 17:52:08]

Patchset 2 (id:??) landed as
https://crrev.com/0071657bfa9bbe25c408068efb0510f696803016
Cr-Commit-Position: refs/heads/master@{#350600}