Animate hiding security button on custom tab toolbar

Animate hiding security button on custom tab toolbar

Currently there is no animation for hiding security button, when we jump
from https to http. This CL fixes it.

BUG=505620
Committed: https://crrev.com/eeadaf507c1033e3235da427224c97a026e15074
Cr-Commit-Position: refs/heads/master@{#340114}

[Ian Wen, 2015-07-21 00:09:28]

ianwen@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2015-07-23 05:21:18]

Looks good. Just a few comments

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java
(right):

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:23:
private View mTitleUrlContainer;
looks like we don't really need to cache this view.

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:24:
private View mSecurityButton;
final

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:26:
private AnimatorSet mSecurityButtonShowAnimator;
final

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:27:
private AnimatorSet mSecurityButtonHideAnimator;
final

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:73:
mSecurityButtonHideAnimator.playSequentially(fadeOut, translateLeft);
I am assuming this works OK for RTL as well?

[Ian Wen, 2015-07-23 17:16:23]

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java
(right):

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:23:
private View mTitleUrlContainer;
On 2015/07/23 05:21:18, Yusuf wrote:
> looks like we don't really need to cache this view.

Done.

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:24:
private View mSecurityButton;
On 2015/07/23 05:21:18, Yusuf wrote:
> final

Done.

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:26:
private AnimatorSet mSecurityButtonShowAnimator;
On 2015/07/23 05:21:18, Yusuf wrote:
> final

Done.

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:27:
private AnimatorSet mSecurityButtonHideAnimator;
On 2015/07/23 05:21:18, Yusuf wrote:
> final

Done.

https://codereview.chromium.org/1247623004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java:73:
mSecurityButtonHideAnimator.playSequentially(fadeOut, translateLeft);
On 2015/07/23 05:21:18, Yusuf wrote:
> I am assuming this works OK for RTL as well?

Looks awesome in RTL. :)

[Yusuf, 2015-07-23 17:18:16]

lgtm

[Ian Wen, 2015-07-23 17:23:34]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2015-07-23 17:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1247623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1247623004/20001

[commit-bot: I haz the power, 2015-07-23 18:09:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-23 18:10:14]

Patchset 2 (id:??) landed as
https://crrev.com/eeadaf507c1033e3235da427224c97a026e15074
Cr-Commit-Position: refs/heads/master@{#340114}