Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed)

Created:
10 years, 2 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, amit, davemoore+watch_chromium.org, dhollowa, o3d-review_googlegroups.com
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

base: Move SplitString functions into the base namespace and update the callers. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62483

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix win bot #

Total comments: 2

Patch Set 5 : brett review, reverted changes in o3d due to it's using an old base revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -147 lines) Patch
M app/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/text_elider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/command_line.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/string_split.h View 2 chunks +1 line, -5 lines 0 comments Download
M base/string_split.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/string_util.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M base/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/breakpad_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_index_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_config_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/version_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_page_sync_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/options/cookies_view_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_package.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_events.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/snippet.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/snippet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/ie_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/nss_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/language_combobox_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/language_order_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_form_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/chunk_range.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_model_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/spellcheck_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/shell_dialogs_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/url_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pepper_plugin_registry.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/zip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/default_plugin/plugin_database_handler.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/installer/util/compat_checks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chrome_process_util_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/selenium/selenium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/startup/startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/dom_checker_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/dispatch.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/aff_reader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_mapping_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_mlsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_windows.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_network_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/hresolv/hresolv.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/label.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_lib_mac.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_lib_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_list.cc View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
webkit/glue/plugins/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_list_win.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
10 years, 2 months ago (2010-10-13 00:27:29 UTC) #1
brettw
LGTM http://codereview.chromium.org/3750001/diff/7001/96 File base/string_util.h (right): http://codereview.chromium.org/3750001/diff/7001/96#newcode30 base/string_util.h:30: using base::SplitString; // Hack until we fix the ...
10 years, 2 months ago (2010-10-13 16:36:33 UTC) #2
tfarina
10 years, 2 months ago (2010-10-13 23:53:28 UTC) #3
http://codereview.chromium.org/3750001/diff/7001/96
File base/string_util.h (right):

http://codereview.chromium.org/3750001/diff/7001/96#newcode30
base/string_util.h:30: using base::SplitString; // Hack until we fix the rlz
library.
On 2010/10/13 16:36:34, brettw wrote:
> I don't think we need the end-of-line comment here since you already have the
> TODO above describing the problem.

Removed. I also reverted the changes under o3d directory, because they are using
a chromium revision that is pretty old and does not contain the latest changes
in string_split.h.

Powered by Google App Engine
This is Rietveld 408576698