chrome/test/startup/startup_test.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/startup/startup_test.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/startup/startup_test.cc

diff --git a/chrome/test/startup/startup_test.cc b/chrome/test/startup/startup_test.cc

index 743b8209a1c4c58a6129ad1ba8f62fbc20f90f69..5fa93801757f95565c9711c9a76e6272f5027252 100644

--- a/chrome/test/startup/startup_test.cc

+++ b/chrome/test/startup/startup_test.cc

@@ -160,7 +160,7 @@ class StartupTest : public UIPerfTest {

{

std::string server_version = automation()->server_version();

std::vector<std::string> version_numbers;

- SplitString(server_version, '.', &version_numbers);

+ base::SplitString(server_version, '.', &version_numbers);

int chrome_buildnum = 0;

ASSERT_TRUE(base::StringToInt(version_numbers[2], &chrome_buildnum));

if (chrome_buildnum < 368) {

« no previous file with comments | « chrome/test/selenium/selenium_test.cc ('k') | chrome/test/ui/dom_checker_uitest.cc » ('j') | no next file with comments »