Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/installer/util/compat_checks.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/default_plugin/plugin_database_handler.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/compat_checks.h" 5 #include "chrome/installer/util/compat_checks.h"
6 6
7 #include "base/registry.h" 7 #include "base/registry.h"
8 #include "base/string_number_conversions.h" 8 #include "base/string_number_conversions.h"
9 #include "base/string_split.h" 9 #include "base/string_split.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 11
12 namespace { 12 namespace {
13 13
14 // SEP stands for Symantec End Point Protection. 14 // SEP stands for Symantec End Point Protection.
15 std::wstring GetSEPVersion() { 15 std::wstring GetSEPVersion() {
16 const wchar_t kProductKey[] = 16 const wchar_t kProductKey[] =
17 L"SOFTWARE\\Symantec\\Symantec Endpoint Protection\\SMC"; 17 L"SOFTWARE\\Symantec\\Symantec Endpoint Protection\\SMC";
18 RegKey key(HKEY_LOCAL_MACHINE, kProductKey, KEY_READ); 18 RegKey key(HKEY_LOCAL_MACHINE, kProductKey, KEY_READ);
19 std::wstring version_str; 19 std::wstring version_str;
20 key.ReadValue(L"ProductVersion", &version_str); 20 key.ReadValue(L"ProductVersion", &version_str);
21 return version_str; 21 return version_str;
22 } 22 }
23 23
24 // The product version should be a string like "11.0.3001.2224". This function 24 // The product version should be a string like "11.0.3001.2224". This function
25 // returns as params the first 3 values. Return value is false if anything 25 // returns as params the first 3 values. Return value is false if anything
26 // does not fit the format. 26 // does not fit the format.
27 bool ParseSEPVersion(const std::wstring& version, int* v0, int* v1, int* v2) { 27 bool ParseSEPVersion(const std::wstring& version, int* v0, int* v1, int* v2) {
28 std::vector<std::wstring> v; 28 std::vector<std::wstring> v;
29 SplitString(version, L'.', &v); 29 base::SplitString(version, L'.', &v);
30 if (v.size() != 4) 30 if (v.size() != 4)
31 return false; 31 return false;
32 if (!base::StringToInt(v[0], v0)) 32 if (!base::StringToInt(v[0], v0))
33 return false; 33 return false;
34 if (!base::StringToInt(v[1], v1)) 34 if (!base::StringToInt(v[1], v1))
35 return false; 35 return false;
36 if (!base::StringToInt(v[2], v2)) 36 if (!base::StringToInt(v[2], v2))
37 return false; 37 return false;
38 return true; 38 return true;
39 } 39 }
(...skipping 11 matching lines...) Expand all
51 51
52 } // namespace 52 } // namespace
53 53
54 bool HasIncompatibleSymantecEndpointVersion(const wchar_t* version) { 54 bool HasIncompatibleSymantecEndpointVersion(const wchar_t* version) {
55 int v0, v1, v2; 55 int v0, v1, v2;
56 std::wstring ver_str(version ? version : GetSEPVersion()); 56 std::wstring ver_str(version ? version : GetSEPVersion());
57 if (!ParseSEPVersion(ver_str, &v0, &v1, &v2)) 57 if (!ParseSEPVersion(ver_str, &v0, &v1, &v2))
58 return false; 58 return false;
59 return IsBadSEPVersion(v0, v1, v2); 59 return IsBadSEPVersion(v0, v1, v2);
60 } 60 }
OLDNEW
« no previous file with comments | « chrome/default_plugin/plugin_database_handler.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698