chrome/app/breakpad_win.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/breakpad_win.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/breakpad_win.cc

diff --git a/chrome/app/breakpad_win.cc b/chrome/app/breakpad_win.cc

index 5d57166ca411247d977e837e913b6ddf20749424..3f4f86208ebfab17660d4d80af68a4a14e0b0de6 100644

--- a/chrome/app/breakpad_win.cc

+++ b/chrome/app/breakpad_win.cc

@@ -409,7 +409,7 @@ bool ShowRestartDialogIfCrashed(bool* exit_now) {

// The CHROME_RESTART var contains the dialog strings separated by '|'.

// See PrepareRestartOnCrashEnviroment() function for details.

std::vector<std::wstring> dlg_strings;

- SplitString(restart_data, L'|', &dlg_strings);

+ base::SplitString(restart_data, L'|', &dlg_strings);

delete[] restart_data;

if (dlg_strings.size() < 3)

return true;

« no previous file with comments | « base/version.cc ('k') | chrome/browser/bookmarks/bookmark_index_unittest.cc » ('j') | no next file with comments »