Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: base/string_split.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/string_split.h ('k') | base/string_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/string_split.cc
diff --git a/base/string_split.cc b/base/string_split.cc
index ca979541aee959e60d713438cbb3e6a921892533..1075610f2c194954782b0aa370063ab885eb31f9 100644
--- a/base/string_split.cc
+++ b/base/string_split.cc
@@ -9,6 +9,8 @@
#include "base/third_party/icu/icu_utf.h"
#include "base/utf_string_conversions.h"
+namespace base {
+
template<typename STR>
static void SplitStringT(const STR& str,
const typename STR::value_type s,
@@ -55,8 +57,6 @@ void SplitString(const std::string& str,
SplitStringT(str, c, true, r);
}
-namespace base {
-
bool SplitStringIntoKeyValues(
const std::string& line,
char key_value_delimiter,
« no previous file with comments | « base/string_split.h ('k') | base/string_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698