chrome/common/extensions/url_pattern.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/url_pattern.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/url_pattern.cc

diff --git a/chrome/common/extensions/url_pattern.cc b/chrome/common/extensions/url_pattern.cc

index 62459a3aedfc5f6272b131effcd5122edadb7422..aa7e25250a73fad3a606d53e3be872a848d25567 100644

--- a/chrome/common/extensions/url_pattern.cc

+++ b/chrome/common/extensions/url_pattern.cc

@@ -112,7 +112,7 @@ bool URLPattern::Parse(const std::string& pattern) {

// The first component can optionally be '*' to match all subdomains.

std::vector<std::string> host_components;

- SplitString(host_, '.', &host_components);

+ base::SplitString(host_, '.', &host_components);

if (host_components[0] == "*") {

match_subdomains_ = true;

host_components.erase(host_components.begin(),

« no previous file with comments | « chrome/browser/webdata/web_database.cc ('k') | chrome/common/pepper_plugin_registry.cc » ('j') | no next file with comments »