chrome/browser/language_combobox_model.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/language_combobox_model.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/language_combobox_model.cc

diff --git a/chrome/browser/language_combobox_model.cc b/chrome/browser/language_combobox_model.cc

index 747862c34cd8d67c072b0b02d77ea2de54e8a6ba..216fed1f02dd41f317454f334fe3d299dc03536a 100644

--- a/chrome/browser/language_combobox_model.cc

+++ b/chrome/browser/language_combobox_model.cc

@@ -60,7 +60,7 @@ void LanguageList::InitNativeNames(

void LanguageList::CopySpecifiedLanguagesUp(const std::string& locale_codes) {

DCHECK(!locale_names_.empty());

std::vector<std::string> locale_codes_vector;

- SplitString(locale_codes, ',', &locale_codes_vector);

+ base::SplitString(locale_codes, ',', &locale_codes_vector);

for (size_t i = 0; i != locale_codes_vector.size(); i++) {

const int locale_index = GetIndexFromLocale(locale_codes_vector[i]);

CHECK_NE(locale_index, -1);

« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/language_order_table_model.cc » ('j') | no next file with comments »