Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: base/process_util_linux.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/command_line.cc ('k') | base/string_split.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_linux.cc
diff --git a/base/process_util_linux.cc b/base/process_util_linux.cc
index 4c034c429fbabe2739637d1cd86538d723fd6964..231db595971faf088dfef9c7469e7921f1304e15 100644
--- a/base/process_util_linux.cc
+++ b/base/process_util_linux.cc
@@ -39,7 +39,7 @@ bool GetProcStats(pid_t pid, std::vector<std::string>* proc_stats) {
std::string mem_stats;
if (!file_util::ReadFileToString(stat_file, &mem_stats))
return false;
- SplitString(mem_stats, ' ', proc_stats);
+ base::SplitString(mem_stats, ' ', proc_stats);
return true;
}
@@ -358,7 +358,7 @@ bool ProcessMetrics::GetWorkingSetKBytes(WorkingSetKBytes* ws_usage) const {
return false;
std::vector<std::string> statm_vec;
- SplitString(statm, ' ', &statm_vec);
+ base::SplitString(statm, ' ', &statm_vec);
if (statm_vec.size() != 7)
return false; // Not the format we expect.
@@ -434,7 +434,7 @@ int ParseProcStatCPU(const std::string& input) {
// 0-indexed 11th and 12th are utime and stime. On two different machines
// I found 42 and 39 fields, so let's just expect the ones we need.
std::vector<std::string> fields;
- SplitString(input.substr(rparen + 2), ' ', &fields);
+ base::SplitString(input.substr(rparen + 2), ' ', &fields);
if (fields.size() < 13)
return -1; // Output not in the format we expect.
« no previous file with comments | « base/command_line.cc ('k') | base/string_split.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698