chrome/renderer/webplugin_delegate_proxy.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/webplugin_delegate_proxy.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/webplugin_delegate_proxy.cc

diff --git a/chrome/renderer/webplugin_delegate_proxy.cc b/chrome/renderer/webplugin_delegate_proxy.cc

index de4381d03f1bc2340009090f818d94ef31eb1d46..fe7e90b324b64d6cfd306ad2348d8872f5ea1ed5 100644

--- a/chrome/renderer/webplugin_delegate_proxy.cc

+++ b/chrome/renderer/webplugin_delegate_proxy.cc

@@ -257,7 +257,7 @@ static bool SilverlightColorIsTransparent(const std::string& color) {

return false;

std::string value_string = color.substr(3, std::string::npos);

std::vector<std::string> components;

- SplitString(value_string, ',', &components);

+ base::SplitString(value_string, ',', &components);

if (components.size() == 4 && !StartsWithASCII(components[0], "1", false))

return true;

} else if (LowerCaseEqualsASCII(color, "transparent")) {