chrome/browser/views/shell_dialogs_win.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/shell_dialogs_win.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/views/shell_dialogs_win.cc

diff --git a/chrome/browser/views/shell_dialogs_win.cc b/chrome/browser/views/shell_dialogs_win.cc

index bd7fb4739524701635590812520d400fa1bdb023..1a4d04a894ebe759a196b4dbc17feb780a76289f 100644

--- a/chrome/browser/views/shell_dialogs_win.cc

+++ b/chrome/browser/views/shell_dialogs_win.cc

@@ -309,7 +309,7 @@ bool SaveFileAsWithFilter(HWND owner,

// instance of null to get to "*.jpg".

std::vector<std::wstring> filters;

if (!filter.empty() && save_as.nFilterIndex > 0)

- SplitString(filter, '\0', &filters);

+ base::SplitString(filter, '\0', &filters);

std::wstring filter_selected;

if (!filters.empty())

filter_selected = filters[(2 * (save_as.nFilterIndex - 1)) + 1];

« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/webdata/web_database.cc » ('j') | no next file with comments »