chrome/browser/download/save_package.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_package.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/save_package.cc

diff --git a/chrome/browser/download/save_package.cc b/chrome/browser/download/save_package.cc

index 51dcfeed6f0092d04756a9eb99194e98701577bc..a148f182b493e3174e4954d73b02ab12e4f60aae 100644

--- a/chrome/browser/download/save_package.cc

+++ b/chrome/browser/download/save_package.cc

@@ -1133,7 +1133,7 @@ FilePath SavePackage::GetSuggestedNameForSaveAs(

if (page_url_ == fixed_up_title_url) {

std::string url_path;

std::vector<std::string> url_parts;

- SplitString(page_url_.path(), '/', &url_parts);

+ base::SplitString(page_url_.path(), '/', &url_parts);

if (!url_parts.empty()) {

for (int i = static_cast<int>(url_parts.size()) - 1; i >= 0; --i) {

url_path = url_parts[i];

« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | chrome/browser/extensions/extension_devtools_events.cc » ('j') | no next file with comments »