webkit/glue/plugins/webplugin_delegate_impl_win.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/plugins/webplugin_delegate_impl_win.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/plugins/webplugin_delegate_impl_win.cc

diff --git a/webkit/glue/plugins/webplugin_delegate_impl_win.cc b/webkit/glue/plugins/webplugin_delegate_impl_win.cc

index 8c8868022e1fea51aecfd34ce507f7f674b9aee0..2a1077533fc5236afd55087de0d3577a371b6c28 100644

--- a/webkit/glue/plugins/webplugin_delegate_impl_win.cc

+++ b/webkit/glue/plugins/webplugin_delegate_impl_win.cc

@@ -289,7 +289,7 @@ WebPluginDelegateImpl::WebPluginDelegateImpl(

} else if (filename == kAcrobatReaderPlugin) {

// Check for the version number above or equal 9.

std::vector<std::wstring> version;

- SplitString(plugin_info.version, L'.', &version);

+ base::SplitString(plugin_info.version, L'.', &version);

if (version.size() > 0) {

int major;

base::StringToInt(version[0], &major);

« no previous file with comments | « webkit/glue/plugins/plugin_list_win.cc ('k') | no next file » | no next file with comments »