Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/search_engines/template_url_model_unittest.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search_engines/template_url_model.cc ('k') | chrome/browser/spellcheck_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_model_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_model_unittest.cc b/chrome/browser/search_engines/template_url_model_unittest.cc
index 3027465748c4f53e3f5511bf9328adc6c53781ad..498d884c2d823bb59a210a0aea2bad08360ddf8f 100644
--- a/chrome/browser/search_engines/template_url_model_unittest.cc
+++ b/chrome/browser/search_engines/template_url_model_unittest.cc
@@ -133,7 +133,7 @@ class TemplateURLModelTest : public testing::Test {
template_url->set_autogenerate_keyword(autogenerate_keyword);
template_url->set_short_name(short_name);
std::vector<std::string> encodings_vector;
- SplitString(encodings, ';', &encodings_vector);
+ base::SplitString(encodings, ';', &encodings_vector);
template_url->set_input_encodings(encodings_vector);
template_url->set_date_created(created_date);
template_url->set_safe_for_autoreplace(safe_for_autoreplace);
@@ -774,8 +774,8 @@ TEST_F(TemplateURLModelTest, BuildQueryTerms) {
if (data[i].result) {
std::vector<std::string> keys;
std::vector<std::string> values;
- SplitString(data[i].keys, ';', &keys);
- SplitString(data[i].values, ';', &values);
+ base::SplitString(data[i].keys, ';', &keys);
+ base::SplitString(data[i].values, ';', &values);
ASSERT_TRUE(keys.size() == values.size());
ASSERT_EQ(keys.size(), terms.size());
for (size_t j = 0; j < keys.size(); ++j) {
@@ -1129,7 +1129,7 @@ TEST_F(TemplateURLModelTest, TestManagedDefaultSearch) {
expected_managed_default1->SetFavIconURL(GURL(kIconURL));
expected_managed_default1->set_short_name(L"test1");
std::vector<std::string> encodings_vector;
- SplitString(kEncodings, ';', &encodings_vector);
+ base::SplitString(kEncodings, ';', &encodings_vector);
expected_managed_default1->set_input_encodings(encodings_vector);
expected_managed_default1->set_show_in_default_list(true);
const TemplateURL* actual_managed_default =
« no previous file with comments | « chrome/browser/search_engines/template_url_model.cc ('k') | chrome/browser/spellcheck_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698