chrome/installer/util/compat_checks.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/compat_checks.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/compat_checks.cc

diff --git a/chrome/installer/util/compat_checks.cc b/chrome/installer/util/compat_checks.cc

index 901e1baa734dacc7a1235bbcadb72735298c95cc..f84a27f0495eea5383081b18d2c9f5ae11e81ee8 100644

--- a/chrome/installer/util/compat_checks.cc

+++ b/chrome/installer/util/compat_checks.cc

@@ -26,7 +26,7 @@ std::wstring GetSEPVersion() {

// does not fit the format.

bool ParseSEPVersion(const std::wstring& version, int* v0, int* v1, int* v2) {

std::vector<std::wstring> v;

- SplitString(version, L'.', &v);

+ base::SplitString(version, L'.', &v);

if (v.size() != 4)

return false;

if (!base::StringToInt(v[0], v0))

« no previous file with comments | « chrome/default_plugin/plugin_database_handler.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »