chrome/browser/chromeos/login/authenticator.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/authenticator.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | chrome/browser/chromeos/options/language_config_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/authenticator.cc

diff --git a/chrome/browser/chromeos/login/authenticator.cc b/chrome/browser/chromeos/login/authenticator.cc

index 1ca3378aaa49aebefbf45cbd81a0d2410367d10b..5287dea2e81a838b13bbd54d157d901e4417b058 100644

--- a/chrome/browser/chromeos/login/authenticator.cc

+++ b/chrome/browser/chromeos/login/authenticator.cc

@@ -24,7 +24,7 @@ Authenticator::~Authenticator() {}

std::string Authenticator::Canonicalize(const std::string& email_address) {

std::vector<std::string> parts;

char at = '@';

- SplitString(email_address, at, &parts);

+ base::SplitString(email_address, at, &parts);

DCHECK_EQ(parts.size(), 2U) << "email_address should have only one @";

RemoveChars(parts[0], ".", &parts[0]);

if (parts[0].find('+') != std::string::npos)