chrome/common/pepper_plugin_registry.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/pepper_plugin_registry.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/pepper_plugin_registry.cc

diff --git a/chrome/common/pepper_plugin_registry.cc b/chrome/common/pepper_plugin_registry.cc

index 7243665a201b1d2106f1ca20170c632da8f1168d..87a2bd36bdfca8b9bbcf66b15baeebf16a296369 100644

--- a/chrome/common/pepper_plugin_registry.cc

+++ b/chrome/common/pepper_plugin_registry.cc

@@ -75,17 +75,17 @@ void PepperPluginRegistry::GetPluginInfoFromSwitch(

// *1( LWS + ";" + LWS + <mime-type> )

std::vector<std::string> modules;

- SplitString(value, ',', &modules);

+ base::SplitString(value, ',', &modules);

for (size_t i = 0; i < modules.size(); ++i) {

std::vector<std::string> parts;

- SplitString(modules[i], ';', &parts);

+ base::SplitString(modules[i], ';', &parts);

if (parts.size() < 2) {

DLOG(ERROR) << "Required mime-type not found";

continue;

}

std::vector<std::string> name_parts;

- SplitString(parts[0], '#', &name_parts);

+ base::SplitString(parts[0], '#', &name_parts);

PepperPluginInfo plugin;

#if defined(OS_WIN)

« no previous file with comments | « chrome/common/extensions/url_pattern.cc ('k') | chrome/common/zip.cc » ('j') | no next file with comments »