net/base/host_mapping_rules.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/host_mapping_rules.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/host_mapping_rules.cc

diff --git a/net/base/host_mapping_rules.cc b/net/base/host_mapping_rules.cc

index a1ec12d013915ac58cf4126cf0558e0420061ebe..effea598a6683e1a3319554bfba07efe34d8526f 100644

--- a/net/base/host_mapping_rules.cc

+++ b/net/base/host_mapping_rules.cc

@@ -69,7 +69,7 @@ bool HostMappingRules::AddRuleFromString(const std::string& rule_string) {

std::string trimmed;

TrimWhitespaceASCII(rule_string, TRIM_ALL, &trimmed);

std::vector<std::string> parts;

- SplitString(trimmed, ' ', &parts);

+ base::SplitString(trimmed, ' ', &parts);

// Test for EXCLUSION rule.

if (parts.size() == 2 && LowerCaseEqualsASCII(parts[0], "exclude")) {

« no previous file with comments | « chrome_frame/metrics_service.cc ('k') | net/base/mime_util.cc » ('j') | no next file with comments »