chrome/browser/first_run/first_run_win.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/first_run_win.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/first_run/first_run_win.cc

diff --git a/chrome/browser/first_run/first_run_win.cc b/chrome/browser/first_run/first_run_win.cc

index 9e078c0497a518ee0893ad71707975b0d11bc448..03ffd56d7578781df533a932fd6d9472988bd480 100644

--- a/chrome/browser/first_run/first_run_win.cc

+++ b/chrome/browser/first_run/first_run_win.cc

@@ -414,7 +414,7 @@ std::string EncodeImportParams(int browser_type, int options,

bool DecodeImportParams(const std::string& encoded, int* browser_type,

int* options, int* skip_first_run_ui, HWND* window) {

std::vector<std::string> parts;

- SplitString(encoded, '@', &parts);

+ base::SplitString(encoded, '@', &parts);

if (parts.size() != 4)

return false;

« no previous file with comments | « chrome/browser/extensions/extension_updater_unittest.cc ('k') | chrome/browser/history/snippet.cc » ('j') | no next file with comments »