app/text_elider.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/text_elider.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: app/text_elider.cc

diff --git a/app/text_elider.cc b/app/text_elider.cc

index 3fdb001f77e0b161a453ab192435102dfb54e40d..4f7ddfbdee1b86c125e2cc296c170498d93518f3 100644

--- a/app/text_elider.cc

+++ b/app/text_elider.cc

@@ -123,7 +123,7 @@ std::wstring ElideUrl(const GURL& url,

if (url.SchemeIsFile()) {

// Split the path string using ":"

std::vector<std::wstring> file_path_split;

- SplitString(url_path, L':', &file_path_split);

+ base::SplitString(url_path, L':', &file_path_split);

if (file_path_split.size() > 1) { // File is of type "file:///C:/.."

url_host.clear();

url_domain.clear();

@@ -164,7 +164,7 @@ std::wstring ElideUrl(const GURL& url,

// Parse url_path using '/'.

std::vector<std::wstring> url_path_elements;

- SplitString(url_path, L'/', &url_path_elements);

+ base::SplitString(url_path, L'/', &url_path_elements);

// Get filename - note that for a path ending with /

// such as www.google.com/intl/ads/, the file name is ads/.

« no previous file with comments | « app/l10n_util.cc ('k') | base/command_line.cc » ('j') | no next file with comments »