Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/default_plugin/plugin_database_handler.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/zip.cc ('k') | chrome/installer/util/compat_checks.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/default_plugin/plugin_database_handler.h" 5 #include "chrome/default_plugin/plugin_database_handler.h"
6 6
7 #include "libxml/parser.h" 7 #include "libxml/parser.h"
8 #include "libxml/xpath.h" 8 #include "libxml/xpath.h"
9 9
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 if (url_for_display != 0) 339 if (url_for_display != 0)
340 plugin_detail->download_url_for_display = true; 340 plugin_detail->download_url_for_display = true;
341 } 341 }
342 } 342 }
343 343
344 plugin_detail->display_name = 344 plugin_detail->display_name =
345 UTF8ToWide(reinterpret_cast<const char*>(plugin_name_val->content)); 345 UTF8ToWide(reinterpret_cast<const char*>(plugin_name_val->content));
346 plugin_detail->download_url = 346 plugin_detail->download_url =
347 reinterpret_cast<const char*>(plugin_download_url_val->content); 347 reinterpret_cast<const char*>(plugin_download_url_val->content);
348 348
349 SplitString(reinterpret_cast<const char*>(plugin_mime_type_vals->content), 349 base::SplitString(
350 kMimeTypeSeparator, &plugin_detail->mime_types); 350 reinterpret_cast<const char*>(plugin_mime_type_vals->content),
351 kMimeTypeSeparator, &plugin_detail->mime_types);
351 352
352 plugin_detail->language = 353 plugin_detail->language =
353 reinterpret_cast<const char*>(plugin_lang_val->content); 354 reinterpret_cast<const char*>(plugin_lang_val->content);
354 355
355 return true; 356 return true;
356 } 357 }
OLDNEW
« no previous file with comments | « chrome/common/zip.cc ('k') | chrome/installer/util/compat_checks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698