chrome/browser/process_singleton_linux.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/process_singleton_linux.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/process_singleton_linux.cc

diff --git a/chrome/browser/process_singleton_linux.cc b/chrome/browser/process_singleton_linux.cc

index f537dba8cee937f3170e929ac8f9fc2170ab656f..fe537d20a2d2be55160a0d50448b9d3339f16a7f 100644

--- a/chrome/browser/process_singleton_linux.cc

+++ b/chrome/browser/process_singleton_linux.cc

@@ -710,7 +710,7 @@ void ProcessSingleton::LinuxWatcher::SocketReader::OnFileCanReadWithoutBlocking(

std::string str(buf_, bytes_read_);

std::vector<std::string> tokens;

- SplitString(str, kTokenDelimiter, &tokens);

+ base::SplitString(str, kTokenDelimiter, &tokens);

if (tokens.size() < 3 || tokens[0] != kStartToken) {

LOG(ERROR) << "Wrong message format: " << str;

« no previous file with comments | « chrome/browser/password_manager/password_form_manager.cc ('k') | chrome/browser/safe_browsing/chunk_range.cc » ('j') | no next file with comments »