net/tools/hresolv/hresolv.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/hresolv/hresolv.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/hresolv/hresolv.cc

diff --git a/net/tools/hresolv/hresolv.cc b/net/tools/hresolv/hresolv.cc

index c5c1976c52de6c9f32e987f6989ebb1f285406e7..b5af4ae439e6d18641c78979dac164662c0def1c 100644

--- a/net/tools/hresolv/hresolv.cc

+++ b/net/tools/hresolv/hresolv.cc

@@ -382,7 +382,7 @@ bool ReadHostsAndTimesFromFile(const FilePath& path,

std::vector<std::string> lines;

// TODO(cbentzel): This should probably handle CRLF-style separators as well.

// Maybe it's worth adding functionality like this to base tools.

- SplitString(file_contents, '\n', &lines);

+ base::SplitString(file_contents, '\n', &lines);

std::vector<std::string>::const_iterator line_end = lines.end();

int previous_timestamp = 0;

for (std::vector<std::string>::const_iterator it = lines.begin();

« no previous file with comments | « net/http/http_stream_factory.cc ('k') | net/websockets/websocket_job_unittest.cc » ('j') | no next file with comments »