Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: base/string_util.h

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/string_split.cc ('k') | base/version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines utility functions for working with strings. 5 // This file defines utility functions for working with strings.
6 6
7 #ifndef BASE_STRING_UTIL_H_ 7 #ifndef BASE_STRING_UTIL_H_
8 #define BASE_STRING_UTIL_H_ 8 #define BASE_STRING_UTIL_H_
9 #pragma once 9 #pragma once
10 10
11 #include <stdarg.h> // va_list 11 #include <stdarg.h> // va_list
12 12
13 #include <string> 13 #include <string>
14 #include <vector> 14 #include <vector>
15 15
16 #include "base/basictypes.h" 16 #include "base/basictypes.h"
17 #include "base/compiler_specific.h" 17 #include "base/compiler_specific.h"
18 #include "base/string16.h" 18 #include "base/string16.h"
19 #include "base/string_piece.h" // For implicit conversions. 19 #include "base/string_piece.h" // For implicit conversions.
20 20
21 // TODO(brettw) remove this dependency. Previously StringPrintf lived in this 21 // TODO(brettw) remove this dependency. Previously StringPrintf lived in this
22 // file. We need to convert the callers over to using stringprintf.h instead 22 // file. We need to convert the callers over to using stringprintf.h instead
23 // and then remove this. 23 // and then remove this.
24 #include "base/stringprintf.h" 24 #include "base/stringprintf.h"
25 25
26 #ifdef RLZ_WIN_LIB_RLZ_LIB_H_ 26 #ifdef RLZ_WIN_LIB_RLZ_LIB_H_
27 // TODO(tfarina): Fix the rlz library to include this instead and remove 27 // TODO(tfarina): Fix the rlz library to include this instead and remove
28 // this include. 28 // this include.
29 #include "base/string_split.h" 29 #include "base/string_split.h"
30 using base::SplitString;
30 #endif // RLZ_WIN_LIB_RLZ_LIB_H_ 31 #endif // RLZ_WIN_LIB_RLZ_LIB_H_
31 32
32 // Safe standard library wrappers for all platforms. 33 // Safe standard library wrappers for all platforms.
33 34
34 namespace base { 35 namespace base {
35 36
36 // C standard-library functions like "strncasecmp" and "snprintf" that aren't 37 // C standard-library functions like "strncasecmp" and "snprintf" that aren't
37 // cross-platform are provided as "base::strncasecmp", and their prototypes 38 // cross-platform are provided as "base::strncasecmp", and their prototypes
38 // are listed below. These functions are then implemented as inline calls 39 // are listed below. These functions are then implemented as inline calls
39 // to the platform-specific equivalents in the platform-specific headers. 40 // to the platform-specific equivalents in the platform-specific headers.
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 #elif defined(WCHAR_T_IS_UTF32) 587 #elif defined(WCHAR_T_IS_UTF32)
587 typedef uint32 Unsigned; 588 typedef uint32 Unsigned;
588 #endif 589 #endif
589 }; 590 };
590 template<> 591 template<>
591 struct ToUnsigned<short> { 592 struct ToUnsigned<short> {
592 typedef unsigned short Unsigned; 593 typedef unsigned short Unsigned;
593 }; 594 };
594 595
595 #endif // BASE_STRING_UTIL_H_ 596 #endif // BASE_STRING_UTIL_H_
OLDNEW
« no previous file with comments | « base/string_split.cc ('k') | base/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698