Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome_frame/chrome_frame_npapi.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_activex.cc ('k') | chrome_frame/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_npapi.cc
diff --git a/chrome_frame/chrome_frame_npapi.cc b/chrome_frame/chrome_frame_npapi.cc
index a4079ca58938b279fa62f3b485c25f50ba19b813..93b53b0256911dfa3d31ffacaa18fac73edcbf89 100644
--- a/chrome_frame/chrome_frame_npapi.cc
+++ b/chrome_frame/chrome_frame_npapi.cc
@@ -212,10 +212,10 @@ bool ChromeFrameNPAPI::Initialize(NPMIMEType mime_type, NPP instance,
} else if (LowerCaseEqualsASCII(argn[i],
kPluginChromeFunctionsAutomatedAttribute)) {
functions_enabled_.clear();
- // SplitString writes one empty entry for blank strings, so we need this
- // to allow specifying zero automation of API functions.
+ // base::SplitString writes one empty entry for blank strings, so we need
+ // this to allow specifying zero automation of API functions.
if (argv[i][0] != '\0')
- SplitString(argv[i], ',', &functions_enabled_);
+ base::SplitString(argv[i], ',', &functions_enabled_);
} else if (LowerCaseEqualsASCII(argn[i], kPluginUseChromeNetwork)) {
chrome_network_arg_set = true;
chrome_network_arg = atoi(argv[i]) ? true : false;
@@ -1321,10 +1321,10 @@ bool ChromeFrameNPAPI::enableExtensionAutomation(NPObject* npobject,
std::string functions_a(functions_str.UTF8Characters,
functions_str.UTF8Length);
- // SplitString writes one empty entry for blank strings, so we need this
- // to allow specifying zero automation of API functions.
+ // base::SplitString writes one empty entry for blank strings, so we need
+ // this to allow specifying zero automation of API functions.
if (functions_a[0] != '\0')
- SplitString(functions_a, ',', &functions);
+ base::SplitString(functions_a, ',', &functions);
}
automation_client_->tab()->SetEnableExtensionAutomation(functions);
« no previous file with comments | « chrome_frame/chrome_frame_activex.cc ('k') | chrome_frame/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698