Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/chunk_range.cc ('k') | chrome/browser/search_engines/template_url_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/protocol_parser.cc
diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc
index c022da4444077475a84c8c40ba34e317e0ad18c4..36f9a74625469d4aea7aa9af736f0d00a6b0c7fc 100644
--- a/chrome/browser/safe_browsing/protocol_parser.cc
+++ b/chrome/browser/safe_browsing/protocol_parser.cc
@@ -83,7 +83,7 @@ bool SafeBrowsingProtocolParser::ParseGetHash(
length -= offset;
std::vector<std::string> cmd_parts;
- SplitString(line, ':', &cmd_parts);
+ base::SplitString(line, ':', &cmd_parts);
if (cmd_parts.size() != 3)
return false;
@@ -151,7 +151,7 @@ bool SafeBrowsingProtocolParser::ParseUpdate(
return false; // Error: bad list format!
std::vector<std::string> cmd_parts;
- SplitString(cmd_line, ':', &cmd_parts);
+ base::SplitString(cmd_line, ':', &cmd_parts);
if (cmd_parts.empty())
return false;
const std::string& command = cmd_parts[0];
@@ -266,7 +266,7 @@ bool SafeBrowsingProtocolParser::ParseChunk(const char* data,
const int line_len = static_cast<int>(cmd_line.length()) + 1;
std::vector<std::string> cmd_parts;
- SplitString(cmd_line, ':', &cmd_parts);
+ base::SplitString(cmd_line, ':', &cmd_parts);
// Handle a possible re-key command.
if (cmd_parts.size() != 4) {
@@ -467,7 +467,7 @@ bool SafeBrowsingProtocolParser::ParseNewKey(const char* chunk_data,
return false;
std::vector<std::string> cmd_parts;
- SplitString(line, ':', &cmd_parts);
+ base::SplitString(line, ':', &cmd_parts);
if (cmd_parts.size() != 3)
return false;
« no previous file with comments | « chrome/browser/safe_browsing/chunk_range.cc ('k') | chrome/browser/search_engines/template_url_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698