Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: base/string_split.h

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process_util_linux.cc ('k') | base/string_split.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/string_split.h
diff --git a/base/string_split.h b/base/string_split.h
index c7cb5e7bed436915f0e730f6662f64c29845677d..9e1af19f2e6475cc7024d8996896cf3d13e845ec 100644
--- a/base/string_split.h
+++ b/base/string_split.h
@@ -12,9 +12,7 @@
#include "base/string16.h"
-// TODO(tfarina): Move the following functions into the namespace and update the
-// callers.
-//-----------------------------------------------------------------------------
+namespace base {
// Splits |str| into a vector of strings delimited by |s|. Append the results
// into |r| as they appear. If several instances of |s| are contiguous, or if
@@ -39,8 +37,6 @@ void SplitString(const std::string& str,
char c,
std::vector<std::string>* r);
-namespace base {
-
bool SplitStringIntoKeyValues(
const std::string& line,
char key_value_delimiter,
« no previous file with comments | « base/process_util_linux.cc ('k') | base/string_split.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698