base/version.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/version.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/version.cc

diff --git a/base/version.cc b/base/version.cc

index 22d0e0419629bb322b5a166f1ec5e1f832da3cfd..9fbcb6a6b7921a42a5c64a5acfa66ccd4df584ac 100644

--- a/base/version.cc

+++ b/base/version.cc

@@ -75,7 +75,7 @@ const std::string Version::GetString() const {

bool Version::InitFromString(const std::string& version_str) {

DCHECK(!is_valid_);

std::vector<std::string> numbers;

- SplitString(version_str, '.', &numbers);

+ base::SplitString(version_str, '.', &numbers);

if (numbers.empty())

return false;

for (std::vector<std::string>::iterator i = numbers.begin();

« no previous file with comments | « base/string_util.h ('k') | chrome/app/breakpad_win.cc » ('j') | no next file with comments »